-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RecVAE model #568
Add RecVAE model #568
Conversation
Thanks for the contribution. This is great! Glancing at the RecVAE model, I do notice that it shares a lot of similarities with some models that we have in Cornac (e.g., VAECF). Is it possible that you can restructure your code accordingly so we can better review and maintain? There are multiple utilities which can be reused instead of developing from scratch. |
"Thank you for your opinion. I will make the necessary revisions based on your request, referencing vaecf." |
I've removed duplicate code such as batch code. |
hey @flywithu, this looks good to me overall. I just have a few comments above that can be easily addressed. Thanks again for this great contribution. |
hi @tqtg |
Description
Add the option to use RecVAE model
Checklist:
README.md
(if you are adding a new model).examples/README.md
(if you are adding a new example).datasets/README.md
(if you are adding a new dataset).