Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ANNs compatible with Experiment #563

Merged
merged 16 commits into from
Dec 12, 2023

Conversation

tqtg
Copy link
Member

@tqtg tqtg commented Dec 8, 2023

Description

We now can compare recommendation performance of an ANN with other models under the same Experiment as demonstrated in the example. Alternatively, ANN can be built from a trained model as before. They're now flexible for different scenarios.

Related Issues

Checklist:

  • I have added tests.
  • I have updated the documentation accordingly.
  • I have updated README.md (if you are adding a new model).
  • I have updated examples/README.md (if you are adding a new example).
  • I have updated datasets/README.md (if you are adding a new dataset).

@tqtg tqtg requested review from lthoang and hieuddo December 9, 2023 18:25
Copy link
Member

@lthoang lthoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tqtg we didn't check if a model is fitted before. Is it better if we just show warnings instead of throwing exception when a model is_fitted? This will not affect execution if someone reuses their model.

@tqtg tqtg merged commit a60bb86 into PreferredAI:master Dec 12, 2023
12 checks passed
@tqtg tqtg deleted the ann-experiment-compatible branch December 12, 2023 23:51
@darrylong darrylong added the feature New feature/enhancement request label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature/enhancement request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants