-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update next-basket evaluation #559
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@lthoang couple of comments:
|
lthoang
force-pushed
the
nbr-batch-iter
branch
2 times, most recently
from
December 6, 2023 19:00
39cdda1
to
c30e382
Compare
lthoang
force-pushed
the
nbr-batch-iter
branch
from
December 6, 2023 19:02
c30e382
to
638004f
Compare
lthoang
changed the title
Fix next-basket evaluation and add batch basket items iteration
Update next-basket evaluation
Dec 7, 2023
@tqtg I have updated the naming for the batch iterations and added some unit tests. |
@lthoang please have a look at some changes that I've made. If everything looks good, please consider wrapping up this PR. |
tqtg
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recent updates in
base_method.py
cause error when run next-basket evaluation.This changes is required.
I have further add a new batch iteration function in next-basket dataset for convenient of getting basket items instead of just basket ids.
GPTop
has been updated also enhance ranking performance.Related Issues
Checklist:
README.md
(if you are adding a new model).examples/README.md
(if you are adding a new example).datasets/README.md
(if you are adding a new dataset).