Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update next-basket evaluation #559

Merged
merged 15 commits into from
Dec 8, 2023
Merged

Conversation

lthoang
Copy link
Member

@lthoang lthoang commented Dec 6, 2023

Description

Recent updates in base_method.py cause error when run next-basket evaluation.

This changes is required.
I have further add a new batch iteration function in next-basket dataset for convenient of getting basket items instead of just basket ids.

  • A more accurate scoring function of GPTop has been updated also enhance ranking performance.

Related Issues

Checklist:

  • I have added tests.
  • I have updated the documentation accordingly.
  • I have updated README.md (if you are adding a new model).
  • I have updated examples/README.md (if you are adding a new example).
  • I have updated datasets/README.md (if you are adding a new dataset).

@lthoang lthoang requested a review from tqtg December 6, 2023 10:12
@tqtg
Copy link
Member

tqtg commented Dec 6, 2023

@lthoang couple of comments:

  • shall we rename the iterators to align with others and the data formats? (e.g., user_basket_iter -> ub_iter). I think they're already quite meaningful and we don't have to name them very long.
  • please consider adding some unit tests for this evaluation method to avoid breaking changes in the future.

@lthoang lthoang force-pushed the nbr-batch-iter branch 2 times, most recently from 39cdda1 to c30e382 Compare December 6, 2023 19:00
@lthoang lthoang changed the title Fix next-basket evaluation and add batch basket items iteration Update next-basket evaluation Dec 7, 2023
@lthoang
Copy link
Member Author

lthoang commented Dec 7, 2023

@tqtg I have updated the naming for the batch iterations and added some unit tests.
In addition, in GPTop model, I added an option to use extra data in UBITJson (e.g., quantity).

@tqtg
Copy link
Member

tqtg commented Dec 7, 2023

@lthoang please have a look at some changes that I've made. If everything looks good, please consider wrapping up this PR.

@lthoang lthoang merged commit af62a20 into PreferredAI:master Dec 8, 2023
12 checks passed
@lthoang lthoang deleted the nbr-batch-iter branch December 8, 2023 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants