Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency install checks for Cython #548

Merged
merged 5 commits into from
Nov 27, 2023

Conversation

darrylong
Copy link
Member

Description

No new breaking change here, we are only enforcing checks to dependencies installed.
This is done as users will be unable to install Cornac from GitHub source should they not have numpy, scipy and Cython installed.

Related Issues

Checklist:

  • I have added tests.
  • I have updated the documentation accordingly.
  • I have updated README.md (if you are adding a new model).
  • I have updated examples/README.md (if you are adding a new example).
  • I have updated datasets/README.md (if you are adding a new dataset).

@darrylong darrylong requested a review from tqtg November 24, 2023 08:42
@darrylong darrylong self-assigned this Nov 24, 2023
@tqtg tqtg marked this pull request as ready for review November 24, 2023 21:47
@darrylong darrylong merged commit 2bdae6d into PreferredAI:master Nov 27, 2023
12 checks passed
@darrylong darrylong deleted the install-source branch November 27, 2023 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants