-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize LightGCN Model #531
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqtg
requested changes
Oct 13, 2023
@darrylong shall we try to clean up this PR and merge it? |
tqtg
reviewed
Oct 17, 2023
LGTM |
tqtg
approved these changes
Oct 17, 2023
darrylong
added a commit
to darrylong/cornac
that referenced
this pull request
Oct 23, 2023
* Generated model base from LightGCN * wip * wip example * add self-connection * refactor code * added sanity check * Changed train batch size in example to 1024 * Updated readme for example folder * Update Readme * update docs * Update block comment * WIP * Updated validation metric * Updated message handling * Added legacy lightgcn for comparison purposes * Changed to follow 'a_k = 1/(k+1)', k instead of i * Changed early stopping technique to follow NGCF * remove test_batchsize, early stop verbose to false * Changed parameters to align with paper and ngcf * refractor codes * update docstring * change param name to 'batch_size' * Fix paper reference --------- Co-authored-by: tqtg <tuantq.vnu@gmail.com> Co-authored-by: Quoc-Tuan Truong <tqtg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optimizing LightGCN model to make it consistent with NGCF model.
Related Issues
Checklist:
README.md
(if you are adding a new model).examples/README.md
(if you are adding a new example).datasets/README.md
(if you are adding a new dataset).