Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCMC Implementation #524

Merged
merged 34 commits into from
Aug 1, 2023
Merged

GCMC Implementation #524

merged 34 commits into from
Aug 1, 2023

Conversation

darrylong
Copy link
Member

@darrylong darrylong commented Jul 28, 2023

Description

Implemented GCMC (Graph Convolutional Matrix Completion) using PyTorch and DGL library.

Checklist:

  • I have added tests.
  • I have updated the documentation accordingly.
  • I have updated README.md (if you are adding a new model).
  • I have updated examples/README.md (if you are adding a new example).
  • I have updated datasets/README.md (if you are adding a new dataset).

@darrylong darrylong requested a review from tqtg July 28, 2023 08:33
@darrylong darrylong self-assigned this Jul 28, 2023
@tqtg
Copy link
Member

tqtg commented Jul 28, 2023

@darrylong let's move all the import statements of additional dependencies (e.g., dgl, torch) inside the functions that require them. We don't have some dependencies pre-installed.

@darrylong
Copy link
Member Author

@tqtg Reorganized codes for better readability, with inner import statements on recom_gcmc.py file. Readmes updated as well.

@darrylong darrylong merged commit 65fe021 into PreferredAI:master Aug 1, 2023
@darrylong darrylong deleted the gcmc-ported branch August 1, 2023 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants