Fixed save and load NARRE model #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we elaborate more on the root cause? Is it because of changes in TensorFlow? Also, do we need to check the load function and make sure it works properly? |
Both tensorflow model and optimizer need to be saved separately (detached from the model). For load function, the optimizer needs the saved weights for enabling adaptive learning rate approaches such as Adam and RMSProp. |
tqtg
reviewed
Jul 16, 2023
| layers.Dropout(rate=self.dropout_rate, name="item_Oi")( | ||
| tf.reduce_sum(layers.Multiply()([item_attention, item_review_h]), 1) | ||
| ) | ||
| self.graph = Model( |
tqtg
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current version cannot save NARRE model when specify
save_dirin Experiment.This change is mandatory for NARRE to save its weights.
Related Issues
Checklist:
README.md(if you are adding a new model).examples/README.md(if you are adding a new example).datasets/README.md(if you are adding a new dataset).