-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deployment SDK to use slugs #17043
Conversation
CodSpeed Performance ReportMerging #17043 will not alter performanceComparing Summary
|
6467278
to
ea20178
Compare
@@ -49,6 +50,7 @@ class Schedule: | |||
day_or: bool = False | |||
active: bool = True | |||
parameters: dict[str, Any] = dataclasses.field(default_factory=dict) | |||
slug: str | None = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will prob fail 3.9 checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
errr or maybe not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The from __future__ import annotations
at the top does some black magic that makes this work in 3.9.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
straightforward, LGTM
Allows the setting of schedule slugs via a
prefect.yaml file
:or via the Python SDK: