Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target wait warning to more specific circumstances #16969

Merged
merged 3 commits into from
Feb 5, 2025
+38 −35
Merged

Target wait warning to more specific circumstances #16969

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f83f06
Target warning to more specific circumstances
cicdw Feb 4, 2025
7c00528
Add suggestion to pause schedules prior to upgrading
cicdw Feb 4, 2025
b443dba
Add test per feedback
cicdw Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/prefect/task_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ def log_finished_message(self) -> None:
display_state = repr(self.state) if PREFECT_DEBUG_MODE else str(self.state)
level = logging.INFO if self.state.is_completed() else logging.ERROR
msg = f"Finished in state {display_state}"
if self.state.is_pending():
if self.state.is_pending() and self.state.name != "NotReady":
msg += (
"\nPlease wait for all submitted tasks to complete"
" before exiting your flow by calling `.wait()` on the "
Expand Down