Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove switching logic within settings config #16961

Merged
merged 5 commits into from
Feb 4, 2025

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Feb 4, 2025

This is making test-writing harder and prevents us from making server changes independently of client changes easily. (ref: #16951 )

@cicdw cicdw added the development Tech debt, refactors, CI, tests, and other related work. label Feb 4, 2025
@cicdw
Copy link
Member Author

cicdw commented Feb 4, 2025

i think the labeler workflow failure is happening off main, so my PR should resolve it

Copy link

codspeed-hq bot commented Feb 4, 2025

CodSpeed Performance Report

Merging #16961 will not alter performance

Comparing remove-test-mode-config-logic (3fe5a6b) with main (31fb757)

Summary

✅ 2 untouched benchmarks

@cicdw cicdw merged commit 20b074c into main Feb 4, 2025
45 of 46 checks passed
@cicdw cicdw deleted the remove-test-mode-config-logic branch February 4, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Tech debt, refactors, CI, tests, and other related work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants