-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add database migration that adds parameter fields to deployment schedules #16947
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm once those imports are updated - did alembic
screw that up somehow?
...s/versions/postgresql/2025_02_03_125146_c163acd7e8e3_add_parameters_column_to_deployment_.py
Outdated
Show resolved
Hide resolved
...tions/versions/sqlite/2025_02_03_125228_67f886da208e_add_parameters_column_to_deployment_.py
Outdated
Show resolved
Hide resolved
i'm honestly not sure how that happened!! |
CodSpeed Performance ReportMerging #16947 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
First step towards supporting per-schedule parameter overrides.