Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add database migration that adds parameter fields to deployment schedules #16947

Merged
merged 4 commits into from
Feb 3, 2025

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Feb 3, 2025

First step towards supporting per-schedule parameter overrides.

@cicdw cicdw added the enhancement An improvement of an existing feature label Feb 3, 2025
Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once those imports are updated - did alembic screw that up somehow?

@cicdw
Copy link
Member Author

cicdw commented Feb 3, 2025

i'm honestly not sure how that happened!!

Copy link

codspeed-hq bot commented Feb 3, 2025

CodSpeed Performance Report

Merging #16947 will not alter performance

Comparing add-params-column (8121606) with main (ec443b9)

Summary

✅ 2 untouched benchmarks

Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cicdw cicdw merged commit d3559ee into main Feb 3, 2025
46 checks passed
@cicdw cicdw deleted the add-params-column branch February 3, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants