Add run_flow_in_subprocess utility
#16802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #16802 will not alter performanceComparing Summary
|
desertaxle
force-pushed
the
refactor-runner-process-handling
branch
2 times, most recently
from
25485cf to
9239c3b
Compare
desertaxle
force-pushed
the
refactor-runner-process-handling
branch
from
36ded36 to
577b457
Compare
desertaxle
changed the title
run_flow_in_subprocess utility
zzstoatzz
reviewed
Jan 28, 2025
| flow: "Flow[..., Any]", | ||
| flow_run: "FlowRun | None" = None, | ||
| parameters: dict[str, Any] | None = None, | ||
| wait_for: Iterable[PrefectFuture[R]] | None = None, |
There was a problem hiding this comment.
sorry, i was late to review, but this shouldn't be R should it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
run_flow_in_subprocessutility, which encapsulates the logic necessary to take an in-memoryFlowobject and run it in a separate process. This utility will be useful when used within theRunner, which can hold onto in-memoryFlowobjects when started viaflow.serverand simplify code retrieval when executing flow runs for remotely stored flows.run_flow_in_subprocessusescloudpickleto serialize the provided flow, parameters, and other kwargs when delegating execution to a subprocess. Subprocesses are created via spawn rather than fork because the flow engine deadlocks when started in a forked process. I haven't yet discovered why it deadlocks in a forked process, but it'd be worthwhile to understand and potentially resolve that behavior.