-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the flow from the quickstart as the basis for the deployment in the scheduling tutorial #16721
Merged
daniel-prefect
merged 9 commits into
main
from
update_code_in_schedule_tutorial_to_match_demo_repo
Jan 15, 2025
Merged
Use the flow from the quickstart as the basis for the deployment in the scheduling tutorial #16721
daniel-prefect
merged 9 commits into
main
from
update_code_in_schedule_tutorial_to_match_demo_repo
Jan 15, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzstoatzz
reviewed
Jan 14, 2025
@daniel-prefect lgtm after formatting |
Co-authored-by: nate nowack <thrast36@gmail.com>
discdiver
reviewed
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except I think there is a spacing issue.
@discdiver You're right. Fixed. |
discdiver
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TY
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scheduling tutorial builds on the quickstart, so the code should also match.
Also, this PR switches to using the same work pool name for both managed (Prefect Cloud) and process (self-hosted) work pool types, so that the deployment code works without modification no matter which option you choose.
Checklist
This pull request references any related issue by including "closes<link to issue>
"If this pull request adds new functionality, it includes unit tests that cover the changesIf this pull request removes docs files, it includes redirect settings inmint.json
.If this pull request adds functions or classes, it includes helpful docstrings.