Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the flow from the quickstart as the basis for the deployment in the scheduling tutorial #16721

Merged

Conversation

daniel-prefect
Copy link
Contributor

@daniel-prefect daniel-prefect commented Jan 14, 2025

The scheduling tutorial builds on the quickstart, so the code should also match.

Also, this PR switches to using the same work pool name for both managed (Prefect Cloud) and process (self-hosted) work pool types, so that the deployment code works without modification no matter which option you choose.

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

@zzstoatzz
Copy link
Collaborator

@daniel-prefect lgtm after formatting

@daniel-prefect daniel-prefect enabled auto-merge (squash) January 14, 2025 23:07
Copy link
Contributor

@discdiver discdiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except I think there is a spacing issue.

docs/v3/tutorials/schedule.mdx Outdated Show resolved Hide resolved
@daniel-prefect
Copy link
Contributor Author

@discdiver You're right. Fixed.

Copy link
Contributor

@discdiver discdiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY

@daniel-prefect daniel-prefect merged commit b9753e4 into main Jan 15, 2025
8 checks passed
@daniel-prefect daniel-prefect deleted the update_code_in_schedule_tutorial_to_match_demo_repo branch January 15, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants