Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helpful error on unhashable parameters #16049

Merged
merged 1 commit into from
Nov 18, 2024
Merged

helpful error on unhashable parameters #16049

merged 1 commit into from
Nov 18, 2024

Conversation

zzstoatzz
Copy link
Collaborator

@zzstoatzz zzstoatzz commented Nov 18, 2024

closes #16042

in cases where a user attempts to pass an unhashable object to a task and we fail to compute a cache key, we should at least raise a helpful error.

I could be convinced that we should somehow attempt to change the items we hash for the key automatically, but I didn't want to start with magic

@zzstoatzz zzstoatzz added the enhancement An improvement of an existing feature label Nov 18, 2024
@zzstoatzz zzstoatzz self-assigned this Nov 18, 2024
Copy link

codspeed-hq bot commented Nov 18, 2024

CodSpeed Performance Report

Merging #16049 will not alter performance

Comparing better-hashing-error (6ffdeff) with main (c2a3fb5)

Summary

✅ 3 untouched benchmarks

@zzstoatzz zzstoatzz force-pushed the better-hashing-error branch from bbd4ff0 to 6ffdeff Compare November 18, 2024 19:37
@zzstoatzz zzstoatzz marked this pull request as ready for review November 18, 2024 19:56
@github-actions github-actions bot added the bug Something isn't working label Nov 18, 2024
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@zzstoatzz zzstoatzz merged commit fdca916 into main Nov 18, 2024
41 checks passed
@zzstoatzz zzstoatzz deleted the better-hashing-error branch November 18, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement An improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error encountered when computing cache key - result will not be persisted
2 participants