[UI v2] Add ability to create new variables #15962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desertaxle
commented
Nov 8, 2024
Comment on lines
+54
to
+62
| try: | ||
| model = await models.variables.create_variable( | ||
| session=session, variable=variable | ||
| ) | ||
| except sa.exc.IntegrityError: | ||
| raise HTTPException( | ||
| status_code=409, | ||
| detail=f"A variable with the name {variable.name!r} already exists.", | ||
| ) |
There was a problem hiding this comment.
This API change ensures a useful error is returned when a variable with the same name already exists.
CodSpeed Performance ReportMerging #15962 will not alter performanceComparing Summary
|
aaazzam
approved these changes
Nov 11, 2024
| body: variable, | ||
| }); | ||
| }, | ||
| onSuccess: () => { |
There was a problem hiding this comment.
Here is where onMutate we should hydrate the variable list view client-side cache, and then OnSettled invalidate the query set. See, e.g. https://tanstack.com/query/latest/docs/framework/react/guides/optimistic-updates
this isn't blocking at all. This is just one of those magical optimistic update things that we can go around and do later.
desertaxle
force-pushed
the
ui-v2-variables
branch
from
e4e95e2 to
cf9c4b8
Compare
zzstoatzz
approved these changes
Nov 11, 2024
desertaxle
force-pushed
the
ui-v2-variables
branch
from
cf9c4b8 to
2f20ea2
Compare
desertaxle
added
the
development
mthatt
pushed a commit
to mthatt/prefect-mihir-docs
that referenced
this pull request
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to create new variables to the v2 UI.
To support this functionality the following
shadcn/uicomponent groups were added:This PR also adds a base
TagsInputcomponent for adding tags to variables and introduces CodeMirror as an input for code and code adjacent inputs. CodeMirror is used for the value input for a variable in this PR.Here are the changes in action:
Listing variables will be in a subsequent PR.