Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jit="off" setting for Postgres DBs #15854

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Oct 29, 2024

The original issue that led to turning off jit when using a Postgres DB has been closed. This PR removes the explicit turning off of the jit setting to resolve issues with environments that don't support this setting.

Closes #14602
Closes #10903

Copy link

codspeed-hq bot commented Oct 29, 2024

CodSpeed Performance Report

Merging #15854 will not alter performance

Comparing remove-postgres-jit (2ad6ec0) with main (7903f46)

Summary

✅ 3 untouched benchmarks

@desertaxle desertaxle changed the title Test if jit="off" setting is still necessary Remove jit="off" setting for Postgres DBs Oct 29, 2024
@github-actions github-actions bot added bug Something isn't working enhancement An improvement of an existing feature performance Related to an optimization or performance improvement labels Oct 29, 2024
@desertaxle desertaxle marked this pull request as ready for review October 29, 2024 21:48
@desertaxle desertaxle merged commit 3c053dc into main Oct 30, 2024
41 checks passed
@desertaxle desertaxle deleted the remove-postgres-jit branch October 30, 2024 03:13
@criskurtin
Copy link

@desertaxle any chance this could be backported to 2.x branch for a 2.20.15 release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement An improvement of an existing feature performance Related to an optimization or performance improvement
Projects
None yet
4 participants