Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in a settings.experiments module #15845

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Conversation

sam-phinizy
Copy link
Contributor

This adds in an Experiments model to the Settings class to store all experimental feature settings

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

@sam-phinizy sam-phinizy force-pushed the sam/add-in-experimental-settings branch 2 times, most recently from 408daad to a40d8d9 Compare October 29, 2024 15:56
@sam-phinizy sam-phinizy force-pushed the sam/add-in-experimental-settings branch from a40d8d9 to 4bb3486 Compare October 29, 2024 16:00
Copy link

codspeed-hq bot commented Oct 29, 2024

CodSpeed Performance Report

Merging #15845 will not alter performance

Comparing sam/add-in-experimental-settings (97833c1) with main (8768ffa)

Summary

✅ 3 untouched benchmarks

Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sam-phinizy sam-phinizy merged commit 7f88577 into main Oct 29, 2024
34 checks passed
@sam-phinizy sam-phinizy deleted the sam/add-in-experimental-settings branch October 29, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants