Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings models for services, events, tasks, and the flow run graph #15776

Merged
merged 18 commits into from
Oct 23, 2024

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Oct 22, 2024

This PR finishes up the model creation for server-side settings. This PR also includes some optimizations to avoid these settings updates affecting performance. The optimizations mainly consist of deferring the loading of valid settings variables and caching the response to prevent recalculation on subsequent calls.

Copy link

codspeed-hq bot commented Oct 22, 2024

CodSpeed Performance Report

Merging #15776 will not alter performance

Comparing create-more-server-settings-models (caa7a1b) with main (9794a7d)

Summary

✅ 3 untouched benchmarks

@desertaxle desertaxle changed the title Create more server settings models Add settings models for services, events, tasks, and the flow run graph Oct 22, 2024
@desertaxle desertaxle marked this pull request as ready for review October 23, 2024 02:15
.github/workflows/python-tests.yaml Show resolved Hide resolved
src/prefect/settings/legacy.py Show resolved Hide resolved
@desertaxle desertaxle merged commit ac567af into main Oct 23, 2024
34 checks passed
@desertaxle desertaxle deleted the create-more-server-settings-models branch October 23, 2024 18:51
@desertaxle desertaxle added the development Tech debt, refactors, CI, tests, and other related work. label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Tech debt, refactors, CI, tests, and other related work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants