-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds server settings models #15758
Adds server settings models #15758
Conversation
CodSpeed Performance ReportMerging #15758 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! just something I thought while reviewing, not necessarily an ask for this PR, do you think its worth adding gt
/ le
for numbers where appropriate?
Yeah, that's a good idea! We can add those at some point. |
91e54f3
to
b740680
Compare
8259038
to
312d765
Compare
312d765
to
0b25738
Compare
This PR adds four new settings models:
ServerSettings
ServerAPISettings
ServerDatabaseSettings
ServerEphemeralSettings
In general, many settings previously in the
PREFECT_API_
namespace will move under theServerSetting
model.Support for the old names is maintained via validation aliases for backward compatibility. A new source
EnvFilterSettingsSource
is also added to be able to filer environment variables. It turns out all entries invalidation_alias
are used to load values via environment variables. I ran into this with theuser
field onServerDatabaseSettings
model since Unix-based operating systems have aUSER
environment variable that was getting picked up. Now, allAliasPath
alias choices will be excluded when looking for values via environment variables.