Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create settings models for flows, results, and runners #15754

Merged
merged 4 commits into from
Oct 21, 2024
Merged

Create settings models for flows, results, and runners #15754

merged 4 commits into from
Oct 21, 2024

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Oct 18, 2024 •
edited
Loading

This PR adds four new settings models:

  • FlowsSettings
  • ResultsSettings
  • RunnerSettings
  • RunnerServerSettings

All names to set settings stay the same except for the following:

  • PREFECT_FLOW_DEFAULT_RETRIES is now PREFECT_FLOWS_DEFAULT_RETRIES
  • PREFECT_FLOW_DEFAULT_RETRIES is now PREFECT_FLOWS_DEFAULT_RETRIES
  • PREFECT_DEFAULT_RESULT_STORAGE_BLOCK is now PREFECT_RESULTS_DEFAULT_STORAGE_BLOCK
  • PREFECT_LOCAL_STORAGE_PATH is now PREFECT_RESULTS_LOCAL_STORAGE_PATH

Support for the old names is maintained via validation aliases for backward compatibility.

@desertaxle desertaxle added the development Tech debt, refactors, CI, tests, and other related work. label Oct 18, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 18, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #15754 will not alter performance

Comparing create-even-more-settings-groups (b740680) with main (92014be)

Summary

✅ 3 untouched benchmarks

@desertaxle desertaxle changed the title Create even more settings groups Create settings models for flows, results, and runners Oct 18, 2024
@desertaxle desertaxle marked this pull request as ready for review October 18, 2024 16:10
Base automatically changed from create-more-settings-groups to main October 18, 2024 22:46
@desertaxle desertaxle force-pushed the create-even-more-settings-groups branch from 91e54f3 to b740680 Compare October 21, 2024 14:59
zzstoatzz
zzstoatzz approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@desertaxle desertaxle merged commit dcf250b into main Oct 21, 2024
34 checks passed
@desertaxle desertaxle deleted the create-even-more-settings-groups branch October 21, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzstoatzz zzstoatzz zzstoatzz approved these changes

@cicdw cicdw Awaiting requested review from cicdw cicdw is a code owner

Assignees
No one assigned
Labels
development Tech debt, refactors, CI, tests, and other related work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@desertaxle @zzstoatzz