Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make task creation and submission logs DEBUG #15631

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

zzstoatzz
Copy link
Collaborator

closes #15627

@github-actions github-actions bot added enhancement An improvement of an existing feature labels Oct 9, 2024
Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@desertaxle
Copy link
Member

Do we want to make task run creation logs debug too?

Copy link

codspeed-hq bot commented Oct 9, 2024

CodSpeed Performance Report

Merging #15631 will not alter performance

Comparing declutter-task-submission-logs (1823704) with main (b1c9d20)

Summary

✅ 3 untouched benchmarks

@zzstoatzz
Copy link
Collaborator Author

zzstoatzz commented Oct 9, 2024

Do we want to make task run creation logs debug too?

@desertaxle I intentionally did not do that here, because then there would be no indication that a task started in the logs, you would only ever see Finished in state Completed(), which I could be convinced is fine

EDIT: we will go ahead and make the creation log DEBUG as well

@zzstoatzz zzstoatzz changed the title make task runner submission log a DEBUG log make task creation and submission logs DEBUG Oct 9, 2024
@zzstoatzz zzstoatzz merged commit 3fadd7f into main Oct 9, 2024
29 of 30 checks passed
@zzstoatzz zzstoatzz deleted the declutter-task-submission-logs branch October 9, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An option to reduce logs generated from Task runs
3 participants