fail correctly if lookup_type throws a KeyError in BaseResult.__new__
#15596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzstoatzz
commented
Oct 7, 2024
| @@ -1155,7 +1155,7 @@ def __new__(cls: Type[Self], **kwargs) -> Self: | |||
| try: | |||
| subcls = lookup_type(cls, dispatch_key=kwargs["type"]) | |||
| except KeyError as exc: | |||
| raise ValidationError(errors=[exc], model=cls) | |||
There was a problem hiding this comment.
this is just invalid use of ValidationError (which cannot be constructed directly like this), leading to this error on the issue
File "/opt/homebrew/anaconda3/envs/env/lib/python3.12/site-packages/prefect/results.py", line 1158, in __new__
raise ValidationError(errors=[exc], model=cls)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: No constructor defined
CodSpeed Performance ReportMerging #15596 will not alter performanceComparing Summary
|
desertaxle
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #15585