Update global-concurrency-limits.mdx - Remove await for task submissions
#15581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sions Awaiting task submissions in the async code examples throws an error with Prefect 3.0. ie: TypeError: object PrefectConcurrentFuture can't be used in 'await' expression Updating the examples so that `await` is no longer included before submitting a task allows them to complete successfully.
biancaines
requested review from
discdiver,
cicdw,
desertaxle and
zzstoatzz
as code owners
zzstoatzz
reviewed
Oct 3, 2024
There was a problem hiding this comment.
thank you @biancaines!
I think that since submit is now a sync method, the parent flows no longer need to be async, and I think it might be confusing to have them async if they're just calling sync methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Awaiting task submissions in the async code examples throws an error with Prefect 3.0. ie:
TypeError: object PrefectConcurrentFuture can't be used in 'await' expression
Updating the examples so that
awaitis no longer included before submitting a task allows them to complete successfully.Checklist
<link to issue>"mint.json.