Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helpful message on 404 with deployment by name #15578

Merged
merged 3 commits into from
Oct 4, 2024
Merged

helpful message on 404 with deployment by name #15578

merged 3 commits into from
Oct 4, 2024

Conversation

zzstoatzz
Copy link
Collaborator

@zzstoatzz zzstoatzz commented Oct 3, 2024

closes #15571

uses difflib to get fuzzy string matching

ObjectNotFound: Deployment 'hello/hello-moo-deng' not found; did you mean 'hello/hello'?

this might be over-wraught, but I do think it will be helpful. very open to suggestions

@github-actions github-actions bot added the enhancement An improvement of an existing feature label Oct 3, 2024
Copy link

codspeed-hq bot commented Oct 3, 2024

CodSpeed Performance Report

Merging #15578 will not alter performance

Comparing fuzzy-match (29ded30) with main (f524dc8)

Summary

✅ 3 untouched benchmarks

@zzstoatzz zzstoatzz marked this pull request as ready for review October 4, 2024 19:15
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dig it!

@zzstoatzz zzstoatzz merged commit 50cedb2 into main Oct 4, 2024
34 checks passed
@zzstoatzz zzstoatzz deleted the fuzzy-match branch October 4, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The name of the flow replaces underscores with dashes, making unintuitive to find a deployment by name
2 participants