Typer 0.12.2 breaks test suite

[aaazzam]

First check

• I added a descriptive title to this issue.
• I used the GitHub search to find a similar issue and didn't find it.
• I searched the Prefect documentation for this issue.
• I checked that this issue is related to Prefect and not one of its dependencies.

Bug summary

Typer 0.12.2 breaks OSS test suite, specifically test_pluralized_subcommands_have_multiple_valid_invocations in our cli tests.

Specifically fastapi/typer#567, which appears to build a list of subcommands for better rendering but in doing so calls max instead of length on an empty array, which throws an error.

Reproduction

run the test suite on 0.12.2

Error

No response

Versions

Version:             2.16.9+17.g3feaafd00.dirty
API version:         0.8.4
Python version:      3.11.8
Git commit:          3feaafd0
Built:               Mon, Apr 8, 2024 1:17 PM
OS/Arch:             darwin/arm64
Profile:             staging
Server type:         cloud

Additional context

No response

[svlandeg]

Sorry about this! I think fastapi/typer#796 will fix things again.

[aaazzam]

Thanks! No worries When you release a fix do you intend to yank 0.12.2 - no worries either way just need to figure out whether I need to exclude it in perpetuity or not

…

On Tue, Apr 9, 2024 at 4:00 AM Sofie Van Landeghem ***@***.***> wrote: Sorry about this! I think fastapi/typer#796 <fastapi/typer#796> will fix things again. — Reply to this email directly, view it on GitHub <#12617 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AH4DG2LWWYIR6XSCNSB7OOTY4ONYTAVCNFSM6AAAAABF5ON5DKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBUGM4DANZSGE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[tiangolo]

Typer 0.12.3 just released 🚀

Thanks @svlandeg for the fix!

[aaazzam]

🙇 @svlandeg and @tiangolo

[svlandeg]

just need to figure out whether I need to exclude it in perpetuity or not

It's up to you, of course, but if this bug was only breaking your test suite I think the new release should fix that for you, as the test suite will always install the latest. Other than that, I'd expect this bug to show up only in edge cases, so I'm not sure it's worth yanking for.

[zhen0]

@aaazzam - since this is fixed in Typer 0.12.3, I'm closing this issue. Feel free to let me know if you want it re-opened.