Enhancement: Support different SLA types #2906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dylanbhughes
commented
Jan 29, 2025
•
dylanbhughes
commented
…ylan/enhancement/dynamic-sla-types
dylanbhughes
changed the title
|
Related to CLOUD-1035 |
dylanbhughes
commented
Jan 29, 2025
| } | ||
|
|
||
| public durationInSeconds(): number { | ||
| return this.trigger.within | ||
| } | ||
|
|
||
| public getSlaType(): string { | ||
| return ServiceLevelAgreementType.TimeToCompletion | ||
| public getSlaDefinitionKeyValuePairs(): { key: string, value: unknown }[] { |
There was a problem hiding this comment.
This is happening because we don't preserve the full state of what a user asked for in the SLA object on the backend. We turn the SLA into an automation and stick some labels on it in the db to preserve the minimal SLA state we need (severity, type, etc) but we don't have the properties exposed in the OSS client. Example:
class FrequencySla:
stale_after: timedelta
flow.deploy(_sla=FrequencySla(severity="minor", stale_after=timedelta(hours=1)))We store automation.labels = {"prefect.sla.severity": "minor", "prefect.sla.type": "FrequencySla"} in the db. So I'm "re-assembling" the interface we provided to the user at deploy time.
znicholasbrown
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.