Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FlowRunMenu components subscribing to the flow run multiple times #2857

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

pleek91
Copy link
Collaborator

@pleek91 pleek91 commented Dec 16, 2024

Description

The FlowRunMenu component accepts a FlowRun but some of the modal components accepts just the id and then created their own subscriptions. We already have events set up for things like refreshing so there isn't any reason these component should do their own subscribing.

This was causing api request spam on the new runs page in cloud because for some reason the batch processor wasn't grouping the requests together (likely due to slightly different intervals due to a rendering waterfall).

@pleek91 pleek91 requested a review from a team as a code owner December 16, 2024 18:30
Copy link
Contributor

@znicholasbrown znicholasbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find

@pleek91 pleek91 merged commit c45095f into main Dec 16, 2024
2 checks passed
@pleek91 pleek91 deleted the clean-up-flow-run-menu-components branch December 16, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants