Merge pull request #2889 from PrefectHQ/dylan/bugfix/stop-displaying-…

…empty-sla Bugfix: stop displaying SLA header if no SLAs
PrefectHQ · Jan 14, 2025 · 5f3a172 · 5f3a172
2 parents 9a2a9b7 + e49289f
commit 5f3a172
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/components/DeploymentDetails.vue b/src/components/DeploymentDetails.vue
@@ -52,7 +52,7 @@
         </template>
       </p-key-value>
 
-      <p-key-value v-if="slas" class="deployment-details__slas" label="Service Level Agreements">
+      <p-key-value v-if="slas && slas.length > 0" class="deployment-details__slas" label="Service Level Agreements">
         <template #value>
           <DeploymentServiceLevelAgreementCard v-for="sla in slas" :key="sla.id" class="deployment-details__sla-cards" :service-level-agreement="sla" />
         </template>

diff --git a/src/components/DeploymentServiceLevelAgreementCard.vue b/src/components/DeploymentServiceLevelAgreementCard.vue
@@ -1,11 +1,11 @@
 <template>
-  <p-card class="deployment-service-level-agreement-card">
+  <p-list-item class="deployment-service-level-agreement-card">
     <p-key-value class="deployment-service-level-agreement-card__item" label="Name" :value="serviceLevelAgreement.name" />
     <p-key-value class="deployment-service-level-agreement-card__item" label="Type" :value="serviceLevelAgreement.getSlaType()" />
     <p-key-value class="deployment-service-level-agreement-card__item" label="Severity" :value="uppercase(serviceLevelAgreement.severity)" />
     <p-key-value v-if="serviceLevelAgreement.description" class="deployment-service-level-agreement-card__item" label="Description" :value="serviceLevelAgreement.description" />
     <p-key-value class="deployment-service-level-agreement-card__item" label="Duration" :value="secondsToString(serviceLevelAgreement.durationInSeconds())" />
-  </p-card>
+  </p-list-item>
 </template>