Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

'Update the pin on prefect version' #100

Merged
merged 7 commits into from
Nov 1, 2023
Merged

Conversation

urimandujano
Copy link
Contributor

As part of our work adding support for Pydantic 2, we removed its pin in
prefect's requirements.txt. This means that it's possible to have
prefect, pydantic>=2, and any version of this collection installed. But,
the collection(s) only support pydantic>=2 in their latest versions. This
PR adds a pin on the collection's requirements.txt to make sure that it is
only installed with the correct version prefect that supports pydantic>=2

@urimandujano urimandujano requested a review from a team as a code owner October 30, 2023 20:39
Copy link
Contributor

@chrisguidry chrisguidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, I think the unit tests were failing so I was never able to get this one updated, fell through the cracks :doh:

@urimandujano
Copy link
Contributor Author

urimandujano commented Nov 1, 2023

I finally got the tests here passing. The upshot is that two default tests (that we inherit from prefect) were failing so I used some good ol' OOP to customize them:

  1. skip a test that will fail on Windows
  2. increase a timeout on a heavy test (ray_task_runner seem to be particularly slow on Windows)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants