-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good! just a couple comments
dbt_cli_profile: Optional[DbtCliProfile] = None, | ||
dbt_client: Optional[dbtRunner] = None, | ||
create_artifact: bool = True, | ||
artifact_key: str = "dbt-build-task-summary", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it make sense to parameterize this for a given task so the user doesn't always overwrite the same key by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going to leave this as the default for the dbt build command because dbt build runs all of the models/tests/snapshots/seeds/etc. We will have other pre-built tasks with their own artifacts for each of the individual node types that I will make sure have unique keys for the artifacts
@robfreedy looks like you might also need |
Closes #176
Executes the 'dbt build' command within a Prefect task, and optionally creates a Prefect artifact summarizing the dbt build results. This is a building block for a future prebuilt dbt_flow() but can be used as an individual task.
Example
Screenshots
Checklist
pre-commit
checks.pre-commit install && pre-commit run --all
locally for formatting and linting.mkdocs serve
view documentation locally.