Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Allow Snowflake private key attribute into generated DBT profile #166

Conversation

ian-thomas-tackle-io
Copy link

Because the private key attribute was not listed in the dictionary of renamed keys, it was left out.

Requires a prefect-snowflake branch installed with this PR applied: PrefectHQ/prefect-snowflake#99 to successfully run the test, test_snowflake_target_configs_get_configs_private_key, as it's expecting the private key to be a string, not bytes.

Example

Screenshots

Checklist

  • References any related issue by including "Closes #" or "Closes ".
    • If no issue exists and your change is not a small fix, please create an issue first.
  • Includes tests or only affects documentation.
  • Passes pre-commit checks.
    • Run pre-commit install && pre-commit run --all locally for formatting and linting.
  • Includes screenshots of documentation updates.
    • Run mkdocs serve view documentation locally.
  • Summarizes PR's changes in CHANGELOG.md

Because the private key attribute was not listed in the dictionary of renamed keys, it was left out.
@ian-thomas-tackle-io ian-thomas-tackle-io requested a review from a team as a code owner December 22, 2023 16:32
@jakedave
Copy link

Thanks @ian-thomas-tackle-io for making this PR - this will be super helpful change for us!

@zzstoatzz it seems like you may be a repo maintainer; would it be possible to get eyes on this?

@zzstoatzz
Copy link
Contributor

hi @ian-thomas-tackle-io and @jakedave - sorry about the delay here.

this change looks good to me, we should explore these failing tests though 🤔

@desertaxle
Copy link
Member

The code for this library has been transfered to https://github.com/PrefectHQ/prefect/tree/main/src/integrations/prefect-dbt. Please open a PR in the new code location if this functionality is still needed!

@desertaxle desertaxle closed this Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants