Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

reduce nesting #389

Merged
merged 1 commit into from
Feb 28, 2024
Merged

reduce nesting #389

merged 1 commit into from
Feb 28, 2024

Conversation

zzstoatzz
Copy link
Contributor

@zzstoatzz zzstoatzz commented Feb 28, 2024 •
edited
Loading

i found it hard to read/follow because of how much nesting there was in _create_task_and_wait_for_start

random edits are from accidentally running ruff format .

@zzstoatzz zzstoatzz marked this pull request as ready for review February 28, 2024 02:39
@zzstoatzz zzstoatzz requested a review from a team as a code owner February 28, 2024 02:39
@zzstoatzz zzstoatzz requested review from kevingrismore and removed request for a team February 28, 2024 02:39
chrisguidry
chrisguidry approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@chrisguidry chrisguidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An improvement, thank you!

@zzstoatzz zzstoatzz merged commit 44cf8e2 into use-recent-ecs-task-revision Feb 28, 2024
6 checks passed
@zzstoatzz zzstoatzz deleted the latest-family-revision-nesting branch February 28, 2024 19:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisguidry chrisguidry chrisguidry approved these changes

@kevingrismore kevingrismore Awaiting requested review from kevingrismore

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zzstoatzz @chrisguidry