Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix s3 prefix path truncations #263

Merged
merged 7 commits into from
May 23, 2023

Conversation

tinvaan
Copy link
Contributor

@tinvaan tinvaan commented May 19, 2023

Closes #253

Checklist

  • References any related issue by including "Closes #" or "Closes ".
    • If no issue exists and your change is not a small fix, please create an issue first.
  • Includes tests or only affects documentation.
  • Passes pre-commit checks.
    • Run pre-commit install && pre-commit run --all locally for formatting and linting.
  • Includes screenshots of documentation updates.
    • Run mkdocs serve view documentation locally.
  • Summarizes PR's changes in CHANGELOG.md

@tinvaan tinvaan requested a review from a team May 19, 2023 03:13
prefect_aws/s3.py Outdated Show resolved Hide resolved
@zanieb
Copy link
Contributor

zanieb commented May 19, 2023

Thanks for contributing!

@tinvaan tinvaan requested review from desertaxle and zanieb May 22, 2023 19:40
@tinvaan
Copy link
Contributor Author

tinvaan commented May 23, 2023

@madkinsz / @desertaxle can one of you review/approve? I've addressed the review comments.

prefect_aws/s3.py Outdated Show resolved Hide resolved
@tinvaan tinvaan requested a review from desertaxle May 23, 2023 16:23
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@desertaxle desertaxle merged commit 5ec0ef1 into PrefectHQ:main May 23, 2023
@tinvaan tinvaan deleted the fix/s3-prefix-truncation branch May 24, 2023 02:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 list_objects prefix is inadvertently truncated
3 participants