Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fixes bug when credentials attribute is used with write_path and read_path #208

Merged
merged 2 commits into from
Feb 8, 2023
Merged

Fixes bug when credentials attribute is used with write_path and read_path #208

merged 2 commits into from
Feb 8, 2023

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Feb 8, 2023 •
edited
Loading

Closes #207

Updated tests to use credentials field instead of aws_credentials and minio_credentials and corrected the resulting errors.

Example

Screenshots

Checklist

  • References any related issue by including "Closes #" or "Closes ".
    • If no issue exists and your change is not a small fix, please create an issue first.
  • Includes tests or only affects documentation.
  • Passes pre-commit checks.
    • Run pre-commit install && pre-commit run --all locally for formatting and linting.
  • Includes screenshots of documentation updates.
    • Run mkdocs serve view documentation locally.
  • Summarizes PR's changes in CHANGELOG.md

@desertaxle desertaxle requested a review from a team February 8, 2023 15:21
zzstoatzz
zzstoatzz approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@desertaxle desertaxle merged commit 7a17997 into main Feb 8, 2023
@desertaxle desertaxle deleted the fix-get-s3-client branch February 8, 2023 15:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zzstoatzz zzstoatzz zzstoatzz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

read_path and write_path fail when credentials attribute is used
2 participants
@desertaxle @zzstoatzz