default gpt-4, failover #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlowin
reviewed
Jan 15, 2024
src/marvin/settings.py
Outdated
| model: str = Field( | ||
| description="The default chat model to use.", default="gpt-3.5-turbo" | ||
| model: str = Field(description="The default chat model to use.", default="gpt-4") | ||
| _fallback_model: str = PrivateAttr( |
There was a problem hiding this comment.
I suggest either making this public or moving it to a global variable in the client module; private settings are going to be very difficult to discover.
There was a problem hiding this comment.
made a var in the client module in a657902
jlowin
reviewed
Jan 15, 2024
src/marvin/settings.py
Outdated
| @@ -44,8 +44,9 @@ def __setattr__(self, name: str, value: Any) -> None: | |||
|
|
|||
| class ChatCompletionSettings(MarvinSettings): | |||
| model_config = SettingsConfigDict(env_prefix="marvin_chat_completion_") | |||
| model: str = Field( | |||
| description="The default chat model to use.", default="gpt-3.5-turbo" | |||
| model: str = Field(description="The default chat model to use.", default="gpt-4") | |||
There was a problem hiding this comment.
Suggested change
| model: str = Field(description="The default chat model to use.", default="gpt-4") | |
| model: str = Field(description="The default chat model to use.", default="gpt-4-1106-preview") |
I think if you have GPT-4 you have the turbo preview, so this is better, cheaper and much larger context
There was a problem hiding this comment.
updated in a657902
jlowin
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.