fix docs build and redo api-ref #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzstoatzz
commented
Dec 6, 2023
| from types import FunctionType, GenericAlias | ||
| from typing import Annotated, Any, Callable, Optional, Union, cast, get_origin | ||
|
|
||
| from pydantic import BaseModel, TypeAdapter, create_model | ||
| from pydantic.v1 import validate_arguments | ||
| from pydantic.deprecated.decorator import validate_arguments |
There was a problem hiding this comment.
because we were using v1's validate_arguments, we were getting v1 BaseModel instances here as well.
probably not ideal to use this (being deprecated) and should switch to validate_call (although I couldn't figure out how to get the model back from that right away, may need TypeAdapter for this?)
aaazzam
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
mkdocs.ymlwas referencing old doc files and was the build was generally broken, this PR:temporary_settingsto handle nested setting objectsparse_as