feat: add Pie and Combined(bar + line) chart in HealthFragment #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PratyushSingh07
requested changes
Dec 22, 2023
app/src/main/java/com/example/cyclofit/ui/fragment/TimeCombinedChartFragment.kt
Outdated
Show resolved
Hide resolved
Comment on lines
17
to
19
| val months = arrayOf( | ||
| "Jan", "Feb", "Mar", "Apr", "May", "Jun", "Jul", "Aug", "Sep", "Okt", "Nov", "Dec" | ||
| ) |
There was a problem hiding this comment.
Use enums instead of an array. Also make sure that you define them in a separate file. So basically make an Enum by the name of Months.kt and define months there
app/src/main/java/com/example/cyclofit/ui/fragment/KcalCombinedChartFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/example/cyclofit/ui/fragment/KcalCombinedChartFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/example/cyclofit/ui/fragment/KcalCombinedChartFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/example/cyclofit/ui/fragment/DistanceCombineChartFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/example/cyclofit/ui/fragment/DistanceCombineChartFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/example/cyclofit/ui/adapter/CombinedChartAdapter.kt
Outdated
Show resolved
Hide resolved
PratyushSingh07
requested changes
Dec 22, 2023
Comment on lines
16
to
29
| enum class Months { | ||
| Jan, | ||
| Feb, | ||
| Mar, | ||
| Apr, | ||
| May, | ||
| Jun, | ||
| Jul, | ||
| Aug, | ||
| Sep, | ||
| Oct, | ||
| Nov, | ||
| Dec | ||
| } |
There was a problem hiding this comment.
put this inside of a new file . I had told you to put this inside Months.kt
|
please squash your commits. To squash a commit you can use |
- Add menu(in toolbar) in HealthFragment for changing chart type - Add Pie chart for KCal, Time and Distance in HealthFragment - Add Combined chart for KCal, Time and Distance in HealthFragment
princeraj-pr
force-pushed
the
feat/add-pie-and-combined-chart
branch
from
0731ec1 to
bd35f27
Compare
|
Hey @PratyushSingh07, I fixed all the issues you mentioned in this PR. Please review and merge my PR fast as CodePeak is ending soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Pie and Combined(Bar + Line) chart in HealthFragment
Fixes #13
Screen recording
Record_2023-12-22-13-26-29.mp4