Skip to content

Commit

Permalink
Update: support android version 14 (#42)
Browse files Browse the repository at this point in the history
* update: android version 32 -> 34

* fix: storage permission for android 13

* fix: double splash screen in android 12 or later

I disable the default splash screen but we should consider
migrating to SplashScreen API

* update: android version 32 -> 34

- fix double splash screen in android 12 or later
I disable the default splash screen but we should consider
migrating to SplashScreen API
- add media permission for android 13 or later
  • Loading branch information
princeraj-pr authored Dec 19, 2023
1 parent 4fa74ef commit 3bf7051
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 3 deletions.
4 changes: 2 additions & 2 deletions app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@ plugins {

android {
namespace 'com.example.cyclofit'
compileSdk 32
compileSdk 34

defaultConfig {
applicationId "com.example.cyclofit"
minSdk 23
targetSdk 32
targetSdk 34
versionCode 1
versionName "1.0"

Expand Down
5 changes: 4 additions & 1 deletion app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools">

<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"
android:maxSdkVersion="32" />
<uses-permission android:name="android.permission.READ_MEDIA_IMAGES"/>
<uses-permission android:name="android.permission.INTERNET"/>

<application
Expand Down Expand Up @@ -50,6 +52,7 @@
<activity android:name=".ui.activities.DashboardActivity" />
<activity
android:name=".ui.activities.SplashScreen"
android:theme="@style/Theme.RemoveSplashScreenTheme"
android:exported="true">
<intent-filter>
<action android:name="android.intent.action.MAIN" />
Expand Down
5 changes: 5 additions & 0 deletions app/src/main/res/values/themes.xml
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,9 @@
<item name="cornerSize">16dp</item>
</style>

<!-- Disable Android 12 default splash screen -->
<style name="Theme.RemoveSplashScreenTheme" parent="@style/Theme.CycloFit">
<item name="android:windowIsTranslucent">true</item>
</style>

</resources>

0 comments on commit 3bf7051

Please sign in to comment.