Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix how we pass the log directory to Editor Services #4933

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

andyleejordan
Copy link
Member

Requires the related changes to Editor Services, and now our log files make sense, hooray!

Requires PowerShell/PowerShellEditorServices#2129.

@andyleejordan andyleejordan requested a review from a team February 28, 2024 22:48
@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-Logging labels Feb 28, 2024
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan
Copy link
Member Author

I will re-run these after the required PR is merged!

Requires the related changes to Editor Services, and now our log files make
sense, hooray!
@andyleejordan andyleejordan added this pull request to the merge queue Feb 29, 2024
Merged via the queue into main with commit f4f29f0 Feb 29, 2024
7 checks passed
@andyleejordan andyleejordan deleted the andyleejordan/fix-logs branch February 29, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Logging Issue-Enhancement A feature request (enhancement).
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants