Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attribution error in changelog script, update my email #1539

Merged
merged 1 commit into from
Sep 25, 2018

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Sep 21, 2018

PR Summary

Fixes a bug in the changelog script where we keep thanking someone after we thanked them the first time.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@TylerLeonhardt
Copy link
Member

to be clear we will continue to thank them continuously in person 🙌

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjmholt rjmholt merged commit 5419ed9 into PowerShell:master Sep 25, 2018
@rjmholt rjmholt deleted the changelog-script-attribution-fix branch December 12, 2018 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants