Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2.0.0 to AppVeyor builds #1530

Merged
merged 3 commits into from
Sep 20, 2018
Merged

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Sep 13, 2018

Adds the 2.0.0 branch to the AppVeyor build list so we can get a 2.0.0 release artefact.

Not sure what develop was, but I'm pretty sure we're not using it any more.

Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉

@TylerLeonhardt
Copy link
Member

I'm confused by this PR... are we going to have a 2.0.0 branch in vscode-powershell as well?

@rjmholt
Copy link
Contributor Author

rjmholt commented Sep 13, 2018

Well, I'm mainly doing it so the client can have a 2.0 version number. But maybe we don't want that?

@SeeminglyScience
Copy link
Collaborator

Definitely need a 2.0 client version since we're dropping older PowerShell versions. Even if it is more or less a dependency change.

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@rjmholt rjmholt merged commit 1f819e2 into PowerShell:master Sep 20, 2018
@rjmholt rjmholt deleted the appveyor-add-2.0.0 branch December 12, 2018 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants