Unfolding not possible

[aeschli]

From @DarkLite1 on September 11, 2018 6:53

Consider the following PowerShell file:

Test.ps1

        $ImportedMatrix = @(Get-ChildItem -Path ImportDir:\* -Include *.xlsx -File).Where({
            $_.FullName -ne $DefaultsItem.FullName}).ForEach({
            Try { 
                $Obj = [PSCustomObject]@{
                    File = @{
                        Item = $_
                        SaveFullName = $_.FullName
                        ExcelInfo = $null
                        LogFolder = $null
                        Check = @()
                    }
                    Settings = @()
                    Permissions = @{ 
                        Import = @()
                        Check = @()
                    }
                }

                $Obj
            }
            Catch {
                Write-Warning $_
                Send-MailHC -To $ScriptAdmin -Subject FAILURE -Priority High -Message $_ -Header $ScriptName
                Write-EventLog @EventErrorParams -Message ($env:USERNAME + ' - ' + "FAILURE:`n`n- " + $_)
                Write-EventLog @EventEndParams; Exit 1
            }
        })

1. Perform the action Fold all with the command palette
2. Try to click the plus sign to unfold, notice that unfolding is not possible with the mouse.

Workarounds:

1. Unfold all with the command palettte.
2. Move the code $_.FullName -ne $DefaultsItem.FullName}).ForEach({ after the Where clause on the same line

Version: 1.28.0-insider (user setup)
Commit: 96854113091424c07b28ba84b82b75a88b8455cb
Date: 2018-09-10T05:18:57.119Z
Electron: 2.0.7
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architecture: x64

Copied from original issue: microsoft/vscode#58414

[aeschli]

It's a problem in the Powershell extension. It returns a range 1-2 which overlaps with the next range.

[TylerLeonhardt]

Thanks @aeschli and sorry @DarkLite1 for the running around. We'll look into this.

[TylerLeonhardt]

I was able to repro this. cc'ing @glennsarti who worked on this feature :) I wonder if this is related to the fact that there is a ({ next to each other - followed by a }) further down.

[glennsarti]

Ahh ok...so overlapping ranges are a problem. Previous testing showed this wasn't the case. Okay...time to trim the ranges then!

[glennsarti]

Repro'd locally myself too ... working on fix.

[TylerLeonhardt]

@glennsarti thanks for jumping on this! You're the best 👍

[glennsarti]

@tylerl0706 Fix is up in PR 1525. Just waiting on green CI.

[glennsarti]

@DarkLite1 Thanks for the issue report and providing an example script. Makes debugging SO much easier and faster bugfix turnaround!

[DarkLite1]

You're welcome and thanks for the fast fix 👍 I just hope #1517 gets some TLC too, as this is a very very annoying one when working with HTML. But that's another topic.

Thanks guys, really appreciate your help.