Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new release steps in release YAML #14583

Closed
rjmholt opened this issue Jan 8, 2021 · 11 comments
Closed

Add new release steps in release YAML #14583

rjmholt opened this issue Jan 8, 2021 · 11 comments
Labels
Area-Maintainers-Build specific to affecting the build Issue-Enhancement the issue is more of a feature request than a bug Resolution-No Activity Issue has had no activity for 6 months or more

Comments

@rjmholt
Copy link
Collaborator

rjmholt commented Jan 8, 2021

There are some release steps for PowerShell that need to be included in the YAML, first as manual steps and then hopefully as automated ones (ideally turned into GH actions if possible).

  • The winget release
  • The step to merge the preview branch, if required
  • The MSIX store release submission step

Also we should add logic to skip (rather than fail) the global tool step for preview releases.

@rjmholt rjmholt added Issue-Enhancement the issue is more of a feature request than a bug Area-Maintainers-Build specific to affecting the build labels Jan 8, 2021
@mi-hol
Copy link

mi-hol commented Jul 26, 2021

Also we should add logic to skip (rather than fail) the global tool step for preview releases.

I've read in other places that winget will provide pre-releases too. Above statements seems to contradict them.
Could availability of preview release via winget be clarified please?

@rjmholt
Copy link
Collaborator Author

rjmholt commented Jul 27, 2021

Could availability of preview release via winget be clarified please?

We currently release previews to winget and don't intend to change that

@mi-hol
Copy link

mi-hol commented Jul 28, 2021

while this patch was merged that should enable powershell-preview 8 around the time you replied.
Trying to install it via winget still fails in Germany.
Is there a delay, after merge completed, that I need to consider?

'''
winget install --name PowerShell-Preview --exact
Es wurde kein Paket gefunden, das den Eingabekriterien entspricht.
'''
error message above translates to "No package that meets the input criteria was found."

@mi-hol
Copy link

mi-hol commented Jul 28, 2021

Trying to install it via winget still fails in Germany.
Is there a delay, after merge completed, that I need to consider?

or is it caused by "PackageLocale: en-US" ?

I found it installs on PC in Germany with display language set to English but not when display language is set to "Deutsch"

Example for failed installation:

get-culture

LCID             Name             DisplayName
----             ----             -----------
1031             de-DE            Deutsch (Deutschland)

winget install --name PowerShell-Preview --exact
Es wurde kein Paket gefunden, das den Eingabekriterien entspricht.

Example for working installation:

get-culture

LCID             Name             DisplayName
----             ----             -----------
1031             de-DE            German (Germany)

@rjmholt
Copy link
Collaborator Author

rjmholt commented Jul 28, 2021

@mi-hol I've discussed your issue in the linked winget issue and it looks like the issue is one of case-sensitivity. See microsoft/winget-pkgs#22522 (comment).

@mi-hol
Copy link

mi-hol commented Jul 29, 2021

Thanks for following up, now new topics come to mind.

  1. "case-sensitivity" sounds like violating the basic Windows concept of being "case insensitive".
  2. From my view there is currently an inconsistent "naming" of pwsh "Preview" release compared to other MSFT products that leads to confusions. Only pwsh naming uses a dot as name separator, in other cases a dash or no separator is used. This inconsistency is basically asking for human error to happen on both sides (developers and users)
  3. changing these "name strings" in many places manually for every release, consumes a lot of effort and introduces a high risk of error. How about using a template pre-processor and a single config file for the string value to auto-generate the correct config files consistently? This would be along the lines of "using automation for building automation tools"
winget search preview
Name                                       Id                                              Version         Match
-------------------------------------------------------------------------------------------------------------------------

PowerShell Preview                         Microsoft.PowerShell.Preview                    7.2.0.8         Tag: preview
Windows Terminal Preview                   Microsoft.WindowsTerminalPreview                1.10.1933.0
Visual Studio Professional 2019 Preview    Microsoft.VisualStudio.2019.Professional-Preview 16.11.31320.298
Visual Studio Enterprise 2019 Preview      Microsoft.VisualStudio.2019.Enterprise-Preview  16.11.31320.298
Visual Studio Community 2019 Preview       Microsoft.VisualStudio.2019.Community-Preview   16.11.31320.298
Microsoft Teams Preview                    Microsoft.TeamsPreview                          1.4.00.18264
Microsoft .NET SDK Preview                 Microsoft.dotnetPreview                         6.1.21.30213
Visual Studio Enterprise 2022 Preview      Microsoft.VisualStudio.2022.Enterprise-Preview  17.0.31423.177
Visual Studio Community 2022 Preview       Microsoft.VisualStudio.2022.Community-Preview   17.0.31423.177
Visual Studio Professional 2022 Preview    Microsoft.VisualStudio.2022.Professional-Preview 17.0.31423.177
PowerToys (Preview)                        Microsoft.PowerToys                             0.41.4
Azure IoT Explorer (preview)               Microsoft.azure-iot-explorer                    0.14.4.0
AppInstaller File Builder(Preview)         Microsoft.AppInstallerFileBuilder               1.2020.221.0

@rjmholt
Copy link
Collaborator Author

rjmholt commented Jul 29, 2021

"case-sensitivity" sounds like violating the basic Windows concept of being "case insensitive".

This is an issue for winget, please open an issue there.

From my view there is currently an inconsistent "naming" of pwsh "Preview" release compared to other MSFT products that leads to confusions. Only pwsh naming uses a dot as name separator, in other cases a dash or no separator is used. This inconsistency is basically asking for human error to happen on both sides (developers and users)

Yeah, I've opened #15836 to track updating our winget automation to standardise the manifests we generate better.

changing these "name strings" in many places manually for every release, consumes a lot of effort and introduces a high risk of error. How about using a template pre-processor and a single config file for the string value to auto-generate the correct config files consistently? This would be along the lines of "using automation for building automation tools"

We automate the process with this script, which needs updating. However, the community often gets their winget updates merged first, which is an issue for consistency.

@mi-hol at this point I think your discussion should be moved to #15836, since it's not on topic for this issue.

Copy link
Contributor

This issue has not had any activity in 6 months, if this is a bug please try to reproduce on the latest version of PowerShell and reopen a new issue and reference this issue if this is still a blocker for you.

2 similar comments
Copy link
Contributor

This issue has not had any activity in 6 months, if this is a bug please try to reproduce on the latest version of PowerShell and reopen a new issue and reference this issue if this is still a blocker for you.

Copy link
Contributor

This issue has not had any activity in 6 months, if this is a bug please try to reproduce on the latest version of PowerShell and reopen a new issue and reference this issue if this is still a blocker for you.

@microsoft-github-policy-service microsoft-github-policy-service bot added Resolution-No Activity Issue has had no activity for 6 months or more labels Nov 16, 2023
Copy link
Contributor

This issue has been marked as "No Activity" as there has been no activity for 6 months. It has been closed for housekeeping purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Maintainers-Build specific to affecting the build Issue-Enhancement the issue is more of a feature request than a bug Resolution-No Activity Issue has had no activity for 6 months or more
Projects
None yet
Development

No branches or pull requests

2 participants