Restore security protocol and use better version using -bor without breaking HTTPS #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Analyzer into RestoreSecurityProtocol # Conflicts: # tools/appveyor.psm1
TravisEz13
reviewed
Oct 30, 2018
| [Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12 # https://github.com/dotnet/announcements/issues/77 | ||
| Invoke-WebRequest 'https://dot.net/v1/dotnet-install.ps1' -OutFile dotnet-install.ps1 | ||
| try { | ||
| $originalSecurityProtocol = [Net.ServicePointManager]::SecurityProtocol |
There was a problem hiding this comment.
You could add an if condition that only changes if [Net.SecurityProtocolType]::Tls12 is not currently added.
There was a problem hiding this comment.
Isn't this what the bitwise operator -bor already does implicitly?
There was a problem hiding this comment.
my point is you could detect that no change is needed... not set $originalSecurityProtocol and not restore it if it is not set.
…nalyzer into RestoreSecurityProtocol
JamesWTruher
approved these changes
Dec 6, 2018
6 tasks
|
Closing since this behaviour has been already implemented by PR #1107 that got merged first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
See title and discussion in PowerShell/PowerShell#6236
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets. Please mark anything not applicable to this PRNA.WIP:to the beginning of the title and remove the prefix when the PR is ready