Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Command data files of PowerShell 6.1.0 and remove 6.0 command data files #1075

Merged
merged 10 commits into from
Mar 2, 2019
Merged

Add Command data files of PowerShell 6.1.0 and remove 6.0 command data files #1075

merged 10 commits into from
Mar 2, 2019

Conversation

bergmeister
Copy link
Collaborator

@bergmeister bergmeister commented Oct 5, 2018 •
edited
Loading

PR Summary

Add command data files for PowerShell 6.1.0 for

  • Windows (Windows 10 1803)
  • Linux (Ubuntu 18.04 and ARM)
  • macOS

Change default target for PowerShell Core from 6.0.2 to 6.1 and remove 6.0 files since 6.0 reached its end of life.

Note that I later also plan to add a special file for Windows 10 1809 in a separate PR, but if anyone else can already do that, that 'd be great

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets. Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • User facing documentation needed
  • Change is not breaking
  • [NA] Make sure you've added a new test if existing tests do not effectively test the code changed
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@bergmeister
Copy link
Collaborator Author

@JamesWTruher @tylerl0706 Can you please upload the command data files for macOS and ARM by running this script in a shell launched by pwsh -noprofile

@bergmeister bergmeister added this to the 1.18 milestone Oct 5, 2018
@bergmeister bergmeister self-assigned this Oct 5, 2018
@TylerLeonhardt
Copy link
Member

Tagging other Mac users who might be able to get to this before me:

@rjmholt @SteveL-MSFT @TravisEz13

@SteveL-MSFT
Copy link
Member

Attached is result from macOS

core-6.1.0-macos.json.txt

@bergmeister
Copy link
Collaborator Author

bergmeister commented Oct 5, 2018 •
edited
Loading

Thanks, if we also could get one from a Raspberry Pi and maybe some OS version info, that'd be great.

@TylerLeonhardt
Copy link
Member

I can supply one for Raspbian sometime this weekend, possibly (maybe Monday).

@TylerLeonhardt
Copy link
Member

Unfortunately, I was pretty rushed leaving for vacation and could not take care of this. I can possibly do it in Singapore at PSConfAsia, or after when I get back (2 weeks).

Or someone else can run the script. Maybe @anmenaga

@bergmeister
Copy link
Collaborator Author

Thanks for the update. I don't think there is a rush or urge for it but it would be a nice to have, so take your time

@TylerLeonhardt
Copy link
Member

Sorry that took a minute. Here's the ARM one from a Raspberry Pi with Raspian on it.

ARM.zip

@bergmeister
Copy link
Collaborator Author

Thanks @tylerl0706

@bergmeister bergmeister added the (Re-)Review Needed Feedback has been addressed during PR stage or is required in the first place. label Jan 29, 2019
@bergmeister bergmeister merged commit dff9522 into PowerShell:development Mar 2, 2019
@bergmeister bergmeister changed the title Add Command data files of PowerShell 6.1.0 Add Command data files of PowerShell 6.1.0 and remove 6.0 command data files Mar 5, 2019
bergmeister added a commit to bergmeister/PSScriptAnalyzer that referenced this pull request Mar 5, 2019
@bergmeister
Add Command data files of PowerShell 6.1.0 (PowerShell#1075)
4fb9df5 
* add command data file for pwsh 6.1.0 on windows 10 1803. Also make it the default reference

* add command date file using Ubuntu 18.04

* update documentation

* add os details about command data files

* Add macOS file from SteveL-MSFT and add to documentation

* Add command data file for raspbian and add to docs. Thanks @tylerl0706

* Remove 6.0.2 files since we have 6.1 files and 6.0 is out of support already

* fix failing test by adapting settings file and add more info to documentation
bergmeister added a commit to bergmeister/PSScriptAnalyzer that referenced this pull request Mar 22, 2019
@bergmeister
Add Command data files of PowerShell 6.1.0 (PowerShell#1075)
7220d74 
* add command data file for pwsh 6.1.0 on windows 10 1803. Also make it the default reference

* add command date file using Ubuntu 18.04

* update documentation

* add os details about command data files

* Add macOS file from SteveL-MSFT and add to documentation

* Add command data file for raspbian and add to docs. Thanks @tylerl0706

* Remove 6.0.2 files since we have 6.1 files and 6.0 is out of support already

* fix failing test by adapting settings file and add more info to documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjmholt rjmholt rjmholt approved these changes

@JamesWTruher JamesWTruher Awaiting requested review from JamesWTruher

@TylerLeonhardt TylerLeonhardt Awaiting requested review from TylerLeonhardt

Assignees

@bergmeister bergmeister

Labels
Area - Engine Breaking Change (Re-)Review Needed Feedback has been addressed during PR stage or is required in the first place.
Projects
None yet
Milestone
1.18
Development

Successfully merging this pull request may close these issues.
4 participants
@bergmeister @TylerLeonhardt @SteveL-MSFT @rjmholt