Refactor for easier testing #897
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
mgovers
reviewed
Feb 17, 2025
..._grid_model_c/power_grid_model/include/power_grid_model/optimizer/tap_position_optimizer.hpp
Outdated
Show resolved
Hide resolved
Comment on lines
590
to
591
| void iterate_ranks(auto const& regulator_order, auto adjust_transformer_in_rank, bool& tap_changed, | ||
| std::vector<IntS>& iterations_per_rank, Idx& rank_index) { |
There was a problem hiding this comment.
do you think it makes more sense to make iterations_per_rank and rank_index member variables (private + public constexpr getters for testability)? The adjust_transformer_in_rank can then be provided into the constructor, and tap_changed can be an output parameter (just like it is for adjust_transformer_in_rank). That way, you can also really test per iteration
There was a problem hiding this comment.
I don't get why we would do that
..._grid_model_c/power_grid_model/include/power_grid_model/optimizer/tap_position_optimizer.hpp
Outdated
Show resolved
Hide resolved
..._grid_model_c/power_grid_model/include/power_grid_model/optimizer/tap_position_optimizer.hpp
Show resolved
Hide resolved
..._grid_model_c/power_grid_model/include/power_grid_model/optimizer/tap_position_optimizer.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
mgovers
reviewed
Feb 17, 2025
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
|
Signed-off-by: petersalemink95 <peter.salemink95@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will not change behavior: only includes a refactor + additional tests