Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libpq-dev to production.Dockerfile #6610

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Add libpq-dev to production.Dockerfile #6610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion production.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ SHELL ["/bin/bash", "-o", "pipefail", "-c"]

# install base dependencies, including node & yarn; remove unneeded build deps
RUN apt-get update \
&& apt-get install -y --no-install-recommends 'curl=7.*' 'git=1:2.*' 'build-essential=12.*' \
&& apt-get install -y --no-install-recommends 'curl=7.*' 'git=1:2.*' 'build-essential=12.*' 'libpq-dev=13.*' \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcushyett-ph highlighted a similar problem in #6330

That was dev though, and I assumed production must have been building successfully. I think this makes sense, I wonder if it's something to do with the base image updating and psycopg-binary not having a prebuilt package for it?

Also, in that other pr it couldn't find libpq-dev=13.* as seen in the comments. I wonder why that doesn't fail here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🕵️ !

Also, in that other pr it couldn't find libpq-dev=13.* as seen in the comments. I wonder why that doesn't fail here?
I'm not sure how we were looking for it but here's the package in the debian/bullseye repository

&& curl -sL https://deb.nodesource.com/setup_14.x | bash - \
&& apt-get install -y --no-install-recommends 'nodejs=14.*' \
&& npm install -g yarn@1 \
Expand Down