fix: add a nice sharing 404 #28065
Merged
fix: add a nice sharing 404 #28065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances the user experience by replacing the default DRF API error page with a custom 404 page for invalid or expired sharing URLs.
- Added new
shared_resource_404.htmltemplate with a space-themed design and PostHog branding - Modified
SharingViewerPageViewSetinposthog/api/sharing.pyto handle NotFound exceptions with custom 404 response - Improved error handling for shared resources that don't exist or are no longer accessible
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+209
to
+211
| def custom_404_response(request): | ||
| """Returns a custom 404 page.""" | ||
| return render(request, "shared_resource_404.html", status=404) |
There was a problem hiding this comment.
style: consider adding request type annotation and docstring with more details about the template context
rafaeelaudibert
approved these changes
Jan 30, 2025
| {% include "head.html" %} | ||
| </head> | ||
| <style> | ||
| html, body, iframe { |
There was a problem hiding this comment.
It would be cool if you could load our font using @font, will look more professional compared to the Times New Roman thing we have going on
veryayskiy
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if someone visits a sharing URL that doesn't exist or doesn't exist any more
they get a DRF API style error page, yuck!