Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: format legacy plugins to new format #28017

Merged
merged 85 commits into from
Feb 4, 2025
Merged

feat: format legacy plugins to new format #28017

merged 85 commits into from
Feb 4, 2025

Conversation

MarconLP
Copy link
Member

@MarconLP MarconLP commented Jan 29, 2025

Changes

  • export LegacyPlugin type at the bottom
  • replace console with logger.log
  • await meta.fetch instead of normal
  • make sure all tests work

status for all plugins: https://docs.google.com/spreadsheets/d/1K7Y5ZaefxP_mGl_q2ubjbFj6NybQT1DB0Q53CsEAMek/edit?usp=sharing

Does this work well for both Cloud and self-hosted?

How did you test this code?

Copy link
Contributor

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to make a few changes to the tests - including the sengrid tests that weren't running. Can you do a double check of everything again just to make sure that the tests really are running correctly please 🙌

@MarconLP MarconLP requested review from benjackwhite and removed request for benjackwhite February 3, 2025 12:27
@MarconLP MarconLP requested a review from benjackwhite February 4, 2025 08:44
@MarconLP MarconLP merged commit 2d77e6b into master Feb 4, 2025
92 checks passed
@MarconLP MarconLP deleted the all-legacy-plugins branch February 4, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants