chore(experiments): Use delta instead of places in tests #27150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilkakkar
reviewed
Dec 24, 2024
| @@ -73,12 +73,12 @@ def run_test(stats_version, calculate_probabilities, are_results_significant, ca | |||
| self.assertEqual(p_value, 1) | |||
|
|
|||
| # Control: ~10% conversion rate with wide interval due to small sample | |||
| self.assertAlmostEqual(intervals["control"][0], 0.055, places=2) # Lower bound ~5.5% | |||
| self.assertAlmostEqual(intervals["control"][1], 0.182, places=2) # Upper bound ~18.2% | |||
| self.assertAlmostEqual(intervals["control"][0], 0.055, delta=0.02) # Lower bound ~5.5% | |||
There was a problem hiding this comment.
this is unexpected to me, is it acceptable for this calculation to return 7.4% instead of 5.5%?
There was a problem hiding this comment.
@neilkakkar We're using the same test against both the first methodology and the second methodology. The two methodologies produce slightly different results (and the first methodology a higher degree of variability), so I've been working around that with delta.
But, it's a good question. I'm going to re-roll this PR and split out the assertions across all of the tests. Thanks for the review!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #26713
Changes
Uses
deltawithassertAlmostEqualinstead ofplacesto account for some degree of variability in statistical evaluations.How did you test this code?
Tests should pass.